potential doesn't erode, but there is a cap. The only times I see where a player doesn't reach his potential is due to low WE.
On the other hand, a players ratings could erode if he doesn't get enough practice, but the potential will always be there.